Misc and minor improvements of syscalls used by VSH #13067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Dec 12, 2022
elad335
reviewed
Dec 12, 2022
elad335
requested changes
Dec 13, 2022
rpcs3/Emu/Cell/lv2/sys_ss.cpp
Outdated
| @@ -146,7 +143,7 @@ s32 sys_ss_get_open_psid(vm::ptr<CellSsOpenPSID> psid) | |||
|
|
|||
| error_code sys_ss_appliance_info_manager(u32 code, vm::ptr<u8> buffer) | |||
| { | |||
| sys_ss.warning("sys_ss_appliance_info_manager(code=0x%x, buffer=*0x%x)", code, buffer); | |||
| sys_ss.trace("sys_ss_appliance_info_manager(code=0x%x, buffer=*0x%x)", code, buffer); | |||
There was a problem hiding this comment.
Don't listen to that dated developer guide, trace is simply put not logged which is not what we want. here you can use notice level.
elad335
approved these changes
Dec 13, 2022
elad335
requested changes
Dec 13, 2022
|
Rebase needed. |
elad335
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly implemented sys_ss_get_console_id(), and added sys_sm_set_shop_mode(), which is used not only by SHOP firmware but also by GEX firmware.