Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Report Game Size On Disk, Make Game Removal An Informed Decision #13088

Merged
merged 1 commit into from
Dec 17, 2022
Merged

UI: Report Game Size On Disk, Make Game Removal An Informed Decision #13088

merged 1 commit into from
Dec 17, 2022

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Dec 17, 2022 •
edited
Loading

  • Add the "Space On Disk" column in the game grid. This also means you can sort games by their size.
  • Report game size and current free space when trying to remove a game to help the user make an informed decision.
    image
    image

@elad335 elad335 requested a review from Megamouse December 17, 2022 08:45
@Megamouse Megamouse added the GUI label Dec 17, 2022
@elad335 elad335 requested a review from Megamouse December 17, 2022 09:37
@elad335 elad335 requested a review from Megamouse December 17, 2022 09:45
@elad335
Copy link
Contributor Author

elad335 commented Dec 17, 2022

Added game sorting by size
image

@elad335 elad335 requested a review from Megamouse December 17, 2022 10:26
elad335
elad335 commented Dec 17, 2022
View reviewed changes
rpcs3/rpcs3qt/game_list_frame.cpp
@@ -2593,6 +2608,7 @@ void game_list_frame::PopulateGameList()
m_game_list->setItem(row, gui::column_last_play, new custom_table_widget_item(locale.toString(last_played, last_played >= QDateTime::currentDateTime().addDays(-7) ? gui::persistent::last_played_date_with_time_of_day_format : gui::persistent::last_played_date_format_new), Qt::UserRole, last_played));
m_game_list->setItem(row, gui::column_playtime, new custom_table_widget_item(elapsed_ms == 0 ? tr("Never played") : localized.GetVerboseTimeByMs(elapsed_ms), Qt::UserRole, elapsed_ms));
m_game_list->setItem(row, gui::column_compat, compat_item);
m_game_list->setItem(row, gui::column_dir_size, new custom_table_widget_item(game_size != umax ? gui::utils::format_byte_size(game_size) : tr("Unknown"), Qt::UserRole, QVariant::fromValue<usz>(game_size)));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromValue because of a compilation issue on GCC/clang.

@Megamouse Megamouse merged commit f54da22 into RPCS3:master Dec 17, 2022
@elad335 elad335 deleted the ui-disk branch December 17, 2022 11:28
@Udderdude Udderdude mentioned this pull request Dec 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Awaiting requested review from Megamouse

Assignees
No one assigned
Labels
GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elad335 @Megamouse