Make game size calculation not affect UI responsiveness #13134
Conversation
|
This only seems to speed up the cancel process. |
elad335
changed the title
|
Okay. |
elad335
changed the title
| @@ -1831,7 +1831,7 @@ bool fs::remove_all(const std::string& path, bool remove_root, bool is_no_dir_ok | |||
| return true; | |||
| } | |||
|
|
|||
| u64 fs::get_dir_size(const std::string& path, u64 rounding_alignment) | |||
| u64 fs::get_dir_size(const std::string& path, u64 rounding_alignment, atomic_t<bool>* cancel_flag) | |||
There was a problem hiding this comment.
why not pass a shared_ptr?
There was a problem hiding this comment.
I don't see a reason to force it here, it only limits design choices.
There was a problem hiding this comment.
One reason would be to prevent regressions or edge cases that lead to the destruction of the source pointer before the threads are finished.
There was a problem hiding this comment.
The lambda captures the shared pointer by value not reference, it is destructed when the lambda itself is destructed (the code inside would be unreachable). As long as any shared pointer instance references the address, the address would not be deallocated.
elad335
changed the title
Attempt to improve #13127