cellSaveData: Slow save completion (brings iconic game save icons back) #13492
Conversation
|
Are you sure the delay isn't expected due to the user prompt? (in case of CELL_SAVEDATA_CBRESULT_OK_LAST) |
|
Officially fixes |
|
It always return OK_LAST in its only savedata callback. But it also does it for when loading the game and I would not expect PS3 to confim loading savedata when booting the game. It also has its own confirmation screen and does not use PS3 savedata UI at all, I expect there is another condition which enables this screen but this game disables it in another way. |
|
Is it autosave/load? Just curious. I wouldn't add additional dialogs to the autosave/load. |
|
Yes these are autosave functions. |
|
Needs testing with DeS/Ds2. Last time we had slow save routines due to io and they became unplayable due to the autosave triggering every few seconds. |
|
Yes because the PPU wasn't sleeping which made the whole emulation get stuck. Real PS3 saving is pretty slow and may take a few seconds. |
|
Tested DeS, it brings its saving icon for half a second as expected and does not stutter. |
elad335
changed the title
|
Also fixes #10569 |
|
Fixes #8251 and fixes getting stuck on the option screen in Thor: God of Thunder. |
|
When testing this PR against #5968 I discovered RPCS3 crashes immediately on launch. It crashes on attempts to load any title, however. Master is okay.
|
|
Fixes #9936 for me |
|
This is amazing, thank you |
|
I'm sorry if this is silly but how do i actually apply this? |
The gane's save thread completed saving too fast which led to save completion to go unnoticed due to of bad game code.
I also expect that this would bring back games' animated saving icons as the saving PPU finally rests for half a second (delaying half a second) letting other threads do work letting the icon time to be displayed.
Fixes #9936 for Jak II for me. This is timing dependant so it needs testing for others.
Fixes #9936
Fixes #10812
Fixes #10569
Fixes #12843
Fixes #8251
Fixes #6508
Fixes #10636