vk: Add support for VK_EXT_custom_border_color #13901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
May 22, 2023
| @@ -286,7 +286,7 @@ namespace vk | |||
| vk::gpu_debug_marker::insert( | |||
| *m_device, | |||
| *m_cb, | |||
| fmt::format("0x%x: Enter %s", m_tag, m_message) | |||
| fmt::format("0x%llx: Enter %s", m_tag, m_message) | |||
There was a problem hiding this comment.
fmt::format doesn't care about these primitive prefixes iirc,
|
Infamous master |
Megamouse
reviewed
May 22, 2023
| { | ||
| if ((color4.r + color4.g + color4.b) > 1.35f) | ||
| { | ||
| //If color elements are brighter than roughly 0.5 average, use white border |
There was a problem hiding this comment.
Suggested change
| //If color elements are brighter than roughly 0.5 average, use white border | |
| // If color elements are brighter than roughly 0.5 average, use white border |
als0, why 0.5 ? it's 1.35 above
There was a problem hiding this comment.
It's about 0.45, though the target is 0.5 with a factor. I must have changed it to fix some game many years ago and forgot to update the comment.
| info.borderColor = border_color; | ||
| info.borderColor = border_color.value; | ||
|
|
||
| VkSamplerCustomBorderColorCreateInfoEXT custom_color_info; |
There was a problem hiding this comment.
doesn't this warn about initialization?
There was a problem hiding this comment.
Nope. All compilers are smart enough to see it is initialized before use.
There was a problem hiding this comment.
"The compiler". Which one xD
This was referenced May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out some games are really using some unusual border colors (e.g transparent white)
Previous fallback will still exist in case of GPUs without support for this.
Also includes a refactor of how we handle optional features, so that a migration up is easier if we decide to raise our base vulkan version to 1.1 or higher.
Fixes #12451