Gran Turismo Improvements #13917
Merged
Gran Turismo Improvements #13917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-11
reviewed
May 24, 2023
rpcs3/Emu/Cell/lv2/sys_timer.cpp
Outdated
| @@ -267,7 +267,8 @@ error_code _sys_timer_start(ppu_thread& ppu, u32 timer_id, u64 base_time, u64 pe | |||
| { | |||
| std::lock_guard lock(timer.mutex); | |||
|
|
|||
| if (!lv2_obj::check(timer.port)) | |||
| // LV2: Simple nullptr check, nothing complex (do not use lv2_obj::check here) | |||
There was a problem hiding this comment.
This comment can be improved by explaining why lv2_obj::check is incorrect here or if maybe it's just unnecessary.
kd-11
reviewed
May 24, 2023
kd-11
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| @@ -3754,7 +3761,7 @@ bool ppu_initialize(const ppu_module& info, bool check_only) | |||
| settings += ppu_settings::accurate_nj_mode, settings -= ppu_settings::fixup_nj_denormals, fmt::throw_exception("NJ Not implemented"); | |||
|
|
|||
| // Write version, hash, CPU, settings | |||
| fmt::append(obj_name, "v5-kusa-%s-%s-%s.obj", fmt::base57(output, 16), fmt::base57(settings), jit_compiler::cpu(g_cfg.core.llvm_cpu)); | |||
| fmt::append(obj_name, "v5-kusa-gt-%s-%s-%s.obj", fmt::base57(output, 16), fmt::base57(settings), jit_compiler::cpu(g_cfg.core.llvm_cpu)); | |||
There was a problem hiding this comment.
Should be just for the test, before merge this should become just v6 I'm guessing
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
Megamouse
reviewed
May 24, 2023
| static_cast<ppu_thread*>(cpu)->gpr[3] = CELL_EBUSY; | ||
| } | ||
|
|
||
| if (mode == 1) |
There was a problem hiding this comment.
Suggested change
| if (mode == 1) | |
| else if (mode == 1) |
|
@elad335 Will this also affect GT5 Prologue and GT6? |
Yes. |
elad335
force-pushed
the
gt5-fix
branch
4 times, most recently
from
b9b5e7c to
7af113a
Compare
|
The audio "desync"(audio cut out) still happens sometimes. The easyest way that works for me is to trigger is to start World Compact Car Race/ Cape ring two times in a row. |
|
this pr has eliminated GT6 desyncs for good. this is amazing. |
This was referenced Jun 2, 2023
|
Use support platforms if you need support, don't ping further in this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been laying low lately because I've been working on imprvements to Gran Turismo 5' stability. After many hours debugging and head-racking here are all the fixes to make GT5 not freeze anymore, enjoy.
One thing to not is that you need RSX FIFO Accuracy set to Atomic and enable Accurate RSX reservation access.
Fixes #10882