Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Rework some settings, Implement 'Show PPU compilation hint' #14005

Merged
merged 19 commits into from
Jun 14, 2023

Conversation

AniLeo
Copy link
Member

@AniLeo AniLeo commented Jun 11, 2023

Changelog:

Add

Move

  • Settings: Move Disable Vertex Cache to Advanced
    • Under GPU group box, MTRSX now works with Vertex Cache so the use cases
      for this settings are very reduced
  • Settings: Move Start Savestates Paused to Emulator
    • Under Emulator Settings groupbox, this is not really an Advanced setting
      thus it's more fitting on the Emulator tab
  • Settings: Move Accurate PPU Saturation Bit to Debug
  • Settings: Move Accurate PPU Non-Java Mode to Debug
  • Settings: Move Accurate PPU Vector NaN Handling to Debug
  • Settings: Move Accurate PPU Float Condition Control to Debug
  • Settings: Move Accurate GETLLAR to Advanced
  • Settings: Move Automatically start games after boot to Debug
  • Settings: Move Accurate SPU DMA to Advanced

Remove

  • Settings: Remove Full Width AVX-512 from the UI
    • This is a very niche setting, so it can remain a config.yml setting only
  • Settings: Remove PPU Interpreter (dynamic)
    • It has been unimplemented for a long while, so no point in displaying
      it, it can be added once the feature is implemented again

Default

  • Settings: Enable Full Width AVX-512 by default
    • It is only known to cause performance hits in old Skylake-X AVX-512 CPUs
      as opposed to the other AVX-512 enabled CPUs, so it should be enabled as
      default

Rename

  • Settings: Rename to Pause emulation after loading savestates
    • Before the setting's name was Start Savestates Paused
  • Settings: Rename to Force GPU Texture Scaling
    • Before the setting's name was Use GPU Texture Scaling

Reorder

  • Settings: Reorder settings in Emulator
  • Settings: Reorder settings in Debug

Hot-reload

Overlay

  • Settings: Add Output Scaling to Home Menu

@AniLeo AniLeo added the GUI label Jun 11, 2023
@AniLeo AniLeo changed the title UX: Moving some settings, implement 'Show PPU compilation hint' UX: Move some settings, Implement 'Show PPU compilation hint' Jun 11, 2023
@AniLeo AniLeo force-pushed the settings branch 2 times, most recently from 2b5093f to bf988db Compare June 11, 2023 20:27
rpcs3/rpcs3qt/settings_dialog.ui Outdated Show resolved Hide resolved
rpcs3/Emu/system_config_types.h Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/emu_settings.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Outdated Show resolved Hide resolved
@Darkhost1999
Copy link
Contributor

I have a suggestion. Can we make the clear Dev_hdd0/tmp setting a global config only option? It doesn't make sense to me to make it every custom config, too.
This option is used to allow people to use mod menus in some games or other sprx mods in games. And afaik, the only file that needed to be deleted inside dev_hdd0/tmp was the turnoff file after VSH closes incorrectly.

@Megamouse
Copy link
Contributor

It makes no sense to make this option global only, if you only want to disable it for some games.

@Darkhost1999
Copy link
Contributor

Darkhost1999 commented Jun 12, 2023

If you boot any game that is not that some game it deletes your mod and you have to remodify the game again and again and again
Cause it's not a game specific path. Game specific configs don't work.

@AniLeo AniLeo force-pushed the settings branch 2 times, most recently from 39ca377 to 0c828d5 Compare June 12, 2023 19:46
@AniLeo AniLeo changed the title UX: Move some settings, Implement 'Show PPU compilation hint' UX: Rework some settings, Implement 'Show PPU compilation hint' Jun 12, 2023
AniLeo added 2 commits June 14, 2023 19:46
It is only known to cause performance hits in old Skylake-X AVX-512 CPUs 
as opposed to the other AVX-512 enabled CPUs, so it should be enabled as 
default
This is a very niche setting, so it can remain a config.yml setting only
@AniLeo AniLeo force-pushed the settings branch 2 times, most recently from a753783 to d66ff01 Compare June 14, 2023 19:02
@AniLeo AniLeo force-pushed the settings branch 3 times, most recently from 8a88de6 to 644d3f6 Compare June 14, 2023 19:42
AniLeo added 5 commits June 14, 2023 20:48
Under GPU group box, MTRSX now works with Vertex Cache so the use cases
for this settings are very reduced
Under Emulator Settings groupbox, this is not really an Advanced setting 
thus it's more fitting on the Emulator tab
@AniLeo AniLeo marked this pull request as ready for review June 14, 2023 20:30
@AniLeo AniLeo self-assigned this Jun 14, 2023
@AniLeo AniLeo merged commit 6dcf630 into RPCS3:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants