Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx-debug: Print number of vertex draw again. #1452

Merged
merged 1 commit into from Jan 26, 2016

Conversation

Projects
None yet
3 participants
@vlj
Copy link
Contributor

commented Jan 25, 2016

No description provided.

@mention-bot

This comment has been minimized.

Copy link

commented Jan 25, 2016

By analyzing the blame information on this pull request, we identified @DHrpcs3, @Nekotekina and @raven02 to be potential reviewers

@@ -316,7 +316,10 @@ namespace rsx

if (capture_current_frame)
{
for (const auto &first_count : first_count_commands)
vertex_draw_count += first_count.second;

This comment has been minimized.

Copy link
@danilaml

danilaml Jan 25, 2016

Contributor

Why it's counting manually and not just size() ?

This comment has been minimized.

Copy link
@vlj

vlj Jan 25, 2016

Author Contributor

first_count is a vector of pair (of u32).

RSX draw/draw indexed calls only draw up to 256 vertexes each. So to draw more complex geometry app needs to issue several draw calls between begin/end pause.

For instance you can't draw 1000 vertex at once. You need to split this :
-begin triangles-
Draw 256 vertexes starting at 0
Draw 256 vertexes starting at 256
Draw 256 vertexes starting at 512
Draw 232 vertexes starting at 768
-end-

the first_count vector records the vertex count and offset of each of these lines. There's not vector involved here and D3D12 don't use a staging vector to store vertex or index values ; they're just copied to dx owned memory directly.

I'm storing the various first/count pair because I'm not sure they always represent a contiguous set of vertex. I never encountered case where there was a "gap" though.

This comment has been minimized.

Copy link
@danilaml

danilaml Jan 25, 2016

Contributor

Yeah, I realized that later. My brain stopped functioning for a second ;P

vlj added a commit that referenced this pull request Jan 26, 2016

Merge pull request #1452 from vlj/rsx-debug
rsx-debug: Print number of vertex draw again.

@vlj vlj merged commit 40fa836 into RPCS3:master Jan 26, 2016

3 checks passed

code-review/pullapprove Approved by vlj
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.