Savestate Fixes part 3 out of 3 #14691
Conversation
elad335
added
CPU
Savestates
|
The game does boot up properly, however this causes more time to build SPU caches, and the performance behaves slower on Midnight Club Los Angeles. Master: PR: |
rpcs3/Emu/Cell/SPURecompiler.cpp
Outdated
| @@ -6071,10 +6170,11 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator | |||
|
|
|||
| for (auto [a2, b2] : sucs) | |||
| { | |||
| auto ins = b2->block->getFirstNonPHI(); | |||
|
|
|||
| continue; | |||
| @@ -4474,6 +4474,11 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator | |||
|
|
|||
| // Store instructions | |||
| std::array<llvm::StoreInst*, s_reg_max> store{}; | |||
|
|
|||
| // Store reordering/elimination protection | |||
| std::array<usz, s_reg_max> store_context_last_id = fill_array<usz>(0); // Protects against illegal forward ordering | |||
There was a problem hiding this comment.
| std::array<usz, s_reg_max> store_context_last_id = fill_array<usz>(0); // Protects against illegal forward ordering | |
| std::array<usz, s_reg_max> store_context_last_id{}; // Protects against illegal forward ordering |
There was a problem hiding this comment.
Dunno what is wrong with being explicit, this is all constexpr anyways so compiler output should be the same.
rpcs3/rpcs3qt/tooltips.h
Outdated
| @@ -52,6 +52,7 @@ class Tooltips : public QObject | |||
| const QString vulkan_async_scheduler = tr("Determines how to schedule GPU async compute jobs when using asynchronous streaming.\nUse 'Safe' mode for more spec compliant behavior at the cost of some CPU overhead. This setting works with all devices.\nUse 'Fast' to use a faster but hacky version. This option is internally disabled for NVIDIA GPUs due to causing GPU hangs."); | |||
| const QString disable_msl_fast_math = tr("Disables Fast Math for MSL shaders, which may violate the IEEE 754 standard.\nDisabling it may fix some artifacts, especially on Apple GPUs, at the cost of performance."); | |||
| const QString suspend_savestates = tr("When this mode is on, emulation exits when saving and the savestate file is concealed after loading it, preventing reuse by RPCS3.\nThis mode is like hibernation of emulation: if you don't want to be able to cheat using savestates when playing the game, consider using this mode.\nDo note that the savestate file is not gone completely, just ignored by RPCS3. You can manually relaunch it if needed."); | |||
| const QString compatible_savestates = tr("When this mode is on, SPU Emulation is optimized for savestates suitability and compatibility instead at the cost of slight performance downgrade.\nIf this mode is off, attempting to make a savestate may result in an SPU pause error in the log that would disallow doing so for some games."); | |||
There was a problem hiding this comment.
When this mode is on, SPU emulation prioritizes savestate compatibility, however, it may reduce performance slightly. \nWhen this mode is off, some games may not allow making a savestate and show an SPU pause error in the log.
elad335
force-pushed
the
bps
branch
2 times, most recently
from
ecf99e4 to
4954d7e
Compare
|
@Ordinary205 Retest. |
|
Still takes the exact same time when building SPU caches. But the performance is slightly better than the master. |
|
The SPU caches can now be finished approximately 14 seconds. |
Makes savestates a thing again.
Fixes #14007