Improve vfs::host::rename #14703
Merged
Improve vfs::host::rename #14703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
reviewed
Oct 3, 2023
rpcs3/Emu/VFS.cpp
Outdated
| @@ -929,9 +929,20 @@ std::string vfs::host::hash_path(const std::string& path, const std::string& dev | |||
|
|
|||
| bool vfs::host::rename(const std::string& from, const std::string& to, const lv2_fs_mount_point* mp, bool overwrite, bool lock) | |||
| { | |||
| if (fs::rename(from, to, overwrite)) | |||
There was a problem hiding this comment.
Not sure this is safe to do...
There was a problem hiding this comment.
The workaround that closes and reopens file handles was added for Windows because sometimes it won't allow to move a directory with opened files in it. If it succeeds once, it should be safe.
There was a problem hiding this comment.
I moved it to lock scope.
elad335
force-pushed
the
bps
branch
3 times, most recently
from
7e9f46e to
37cbb82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid flushing files to disk when not needed.