llvm: add support for LLVM 17 #14720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Oct 7, 2023
Megamouse
reviewed
Oct 8, 2023
Megamouse
added
Build and CI
|
I'm worried about the legacy dead store elimination pass being gone, it's a big optimization for our codegen. From looking at llvm history it looks like the pass has gone to the new pass system which we don't use atm(and would probably require significant rewrite of some systems?). As it is switching to llvm 17 would incur pretty significant performance loss I think. |
|
We have our own version of it in SPU LLVM so it does not matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for LLVM 17. Maybe we should update the submodule too.