Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Vertex program analyser improvements #14804

Merged
merged 2 commits into from
Nov 9, 2023
Merged

rsx: Vertex program analyser improvements #14804

merged 2 commits into from
Nov 9, 2023

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Nov 8, 2023

  • Fixes a bug when the program entry is at the end of an ubershader block. In this scenario, the entry is the dispatch block and the subroutines sit above it which could cause a crash if there is padding in the structure.
  • More aggressive DCE. In case a loop is detected, we don't need to walk the loop again as it will always end the same way. Previously, we walked over the blocks and consumed the tail sections which could add hundreds of instructions of unreachable code at the end of ubershaders.

Closes #13443

kd-11 added 2 commits November 9, 2023 01:30
- Applies more aggressive DCE in the analyser. Dead-code in tails could happen before in some cases.
@kd-11 kd-11 changed the title rsx: Fix vertex program analyser bug rsx: Vertex program analyser improvements Nov 8, 2023
@kd-11 kd-11 merged commit c411300 into RPCS3:master Nov 9, 2023
6 checks passed
@kd-11 kd-11 deleted the maint0 branch November 9, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MotoGP 09/10 Crashes when making it into a race
2 participants