Savestates: Asynchronous compression #14847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
added
Bugfix
Optimization
elad335
force-pushed
the
save-breathe
branch
2 times, most recently
from
b98d005
to
cdde3e8
Compare
Megamouse
reviewed
Nov 28, 2023
Megamouse
reviewed
Nov 28, 2023
rpcs3/Crypto/unzip.cpp
Outdated
| @@ -3,6 +3,8 @@ | |||
|
|
|||
| #include <zlib.h> | |||
|
|
|||
| #include "Emu/savestate_utils.hpp" | |||
There was a problem hiding this comment.
If you need to include this here, something is really wrong with your software design
There was a problem hiding this comment.
More like the naming of the file.
Megamouse
reviewed
Nov 28, 2023
This comment was marked as outdated.
This comment was marked as outdated.
elad335
force-pushed
the
save-breathe
branch
8 times, most recently
from
438e828
to
5715f20
Compare
Take advantage of the new method, remove a method that is not recommended for use.
elad335
force-pushed
the
save-breathe
branch
4 times, most recently
from
4293bff
to
2cf55c1
Compare
elad335
force-pushed
the
save-breathe
branch
from
2cf55c1
to
76e7044
Compare
|
I can confirm that this fixes an issue after installing PS3 firmware, it also boots the game properly after firmware install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #14822, makes the creation of savestates faster.