Typemap: Set init to false after each individual destructor #14931
Conversation
Megamouse
force-pushed
the
debug_overlay
branch
from
4f65d45 to
befa2b6
Compare
|
Great catch!! |
rpcs3/util/fixed_typemap.hpp
Outdated
| @@ -299,21 +299,22 @@ namespace stx | |||
| } | |||
|
|
|||
| // Get actual number of created objects | |||
| u32 _max = 0; | |||
| std::vector<usz> types_to_destroy; | |||
There was a problem hiding this comment.
Althogh this is probably not needed, there must be another way to get the typeinfo index.
There was a problem hiding this comment.
it's wrong anyway, since it's the wrong order.
There was a problem hiding this comment.
probably fixed now
Megamouse
force-pushed
the
debug_overlay
branch
3 times, most recently
from
ed71558 to
0b94b4a
Compare
Megamouse
force-pushed
the
debug_overlay
branch
from
0b94b4a to
a47b60b
Compare
| info->destroy(*--m_order); | ||
|
|
||
| // Set init to false. We don't want other fxo to use this fxo in their destructor. | ||
| m_init[type_index] = false; |
There was a problem hiding this comment.
It's not the same object?
There was a problem hiding this comment.
I mean, move this line to typeinfo::call_dtor. You can cast it there.
There was a problem hiding this comment.
it's a static function...
There was a problem hiding this comment.
Then pass it as argument or smth
There was a problem hiding this comment.
And do it in auto_typemap.hpp too
There was a problem hiding this comment.
Sorry but I don't have the time to make this code even more spaghetti-like
Megamouse
force-pushed
the
debug_overlay
branch
from
a47b60b to
42e8559
Compare
Fixes crashes when fxo destructors call other fxo.