Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: CPU blit refactor and support RSX tiled addressing #14934

Merged
merged 3 commits into from
Dec 26, 2023

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Dec 24, 2023

  • De-spaghettify nv3089::image_in and refactor into readable units.
  • Add support for RSX tiled addressing in the CPU blit path.

Closes #6688

- This function was a disaster with random code added in without much thought over a decade.
- Restructures the logic into decode and transfer steps for easier management.
@kd-11
Copy link
Contributor Author

kd-11 commented Dec 24, 2023

Gets retro/grade back to a playable state, with the caveat that I need to use CPU blit. GPU blit is not possible right now due to an architectural problem with the emulator.

image
image

@Ordinary205
Copy link
Contributor

This PR causes the regression twice on NFS The Run when enabling WCB+RCB+Tiled memory and CPU Blit Emulation.
Regression
RPCS3.log.gz

@legend800
Copy link

No change in Split Second from the issues noted here: #14682 (comment)

PR build:
2023-12-24 10_58_24-FPS_ 29 99 _ Vulkan _ 0 0 29-3be2d623 Alpha _ maint0 _ Split_Second  NPUB30450

Native res=missing effects/smoke
Higher res=effects render but large pixels everywhere

@Darkhost1999
Copy link
Contributor

Regression

How do I make my screen look like yours? Is this in the menus? In the game? Cause when trying to go ingame I get as far as pressing the first buttons and I don't see this at all.

@kd-11
Copy link
Contributor Author

kd-11 commented Dec 24, 2023

This PR causes the regression twice on NFS The Run when enabling WCB+RCB+Tiled memory and CPU Blit Emulation. Regression RPCS3.log.gz

That looks right to me w.r.t other frostbite games. CPU blit simply did not support tiled addressing, so if it was working before it means something else is broken elsewhere. Makes sense though since Rivals also had the same behavior. Some other component in the pipeline is broken and only appears when RSX tiled addressing is enabled.

@Triticum0
Copy link

@kd-11 Tested Mercury Hg Improved a lot you can now finish a level but still not perfect
Pr
NPUB30419_screenshot_2023_12_25_00_10_25
Pr.log.gz

Masters
NPUB30419_screenshot_2023_12_25_00_07_19

RPCS3.log.gz

@Triticum0
Copy link

Chronicles of Riddick: Assault on Dark Athena crashes in the menus using Forced CPU blit so can't be tested

here the log
RPCS3.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Retro/Grade messed up graphics on Vulkan and OpenGL (#6357)
5 participants