sys: Fix hdd game dir name #14956
Merged
sys: Fix hdd game dir name #14956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Dec 29, 2023
Megamouse
force-pushed
the
debug_overlay
branch
3 times, most recently
from
3710f80 to
36f8f25
Compare
Megamouse
force-pushed
the
debug_overlay
branch
from
36f8f25 to
df32230
Compare
|
Tested some of the apps and they don't crash anymore |
elad335
reviewed
Dec 29, 2023
Megamouse
force-pushed
the
debug_overlay
branch
from
df32230 to
bde3afd
Compare
Some games are installed with other dir names than title_id
Megamouse
force-pushed
the
debug_overlay
branch
from
bde3afd to
fa1cfbb
Compare
elad335
approved these changes
Dec 29, 2023
elad335
reviewed
Dec 29, 2023
| @@ -763,7 +763,8 @@ error_code cellGameBootCheck(vm::ptr<u32> type, vm::ptr<u32> attributes, vm::ptr | |||
|
|
|||
| if (_type == u32{CELL_GAME_GAMETYPE_HDD} && dirName) | |||
| { | |||
| strcpy_trunc(*dirName, Emu.GetTitleID()); | |||
| ensure(dir.size() < CELL_GAME_DIRNAME_SIZE); | |||
There was a problem hiding this comment.
We may need to demand it when booting games or going through HDD0/game directories when enumerating for game list.
There was a problem hiding this comment.
There is no evidence that any game even triggers this ensure.
I refuse to spend even a second on this.
"if it ain't broke, don't fix it"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games are installed with other dir names than title id.
fixes #14954