Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl: Speed up program constants upload by switching to glBufferSubData #1500

Merged
merged 1 commit into from Feb 15, 2016

Conversation

Projects
None yet
3 participants
@kd-11
Copy link
Contributor

commented Feb 13, 2016

Program constants are quite small in size, generally less than 32k. Using glBufferSubData is faster by about an order of magnitude which is a significant speedup in games which issue a lot of draw calls.

@kd-11 kd-11 changed the title Speed up program constants upload by switching to glBufferSubData gl: Speed up program constants upload by switching to glBufferSubData Feb 13, 2016

@kd-11 kd-11 force-pushed the kd-11:prog_constants_fix branch 4 times, most recently from 0f8809a to 92c37c7 Feb 13, 2016

@kd-11 kd-11 force-pushed the kd-11:prog_constants_fix branch from 92c37c7 to 6093279 Feb 15, 2016

Speed up program constants upload by switching to glBufferSubData ove…
…r glMapBuffer

Fix initialization for fragment constants buffer

Orphan buffers before update. Remove redundant binding

@kd-11 kd-11 force-pushed the kd-11:prog_constants_fix branch from 6093279 to 2230975 Feb 15, 2016

@tambry

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2016

@vlj Is this mergable?

vlj added a commit that referenced this pull request Feb 15, 2016

Merge pull request #1500 from kd-11/prog_constants_fix
gl: Speed up program constants upload by switching to glBufferSubData

@vlj vlj merged commit 3b7d0bc into RPCS3:master Feb 15, 2016

3 checks passed

code-review/pullapprove Approved by vlj
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlj

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2016

Yes

@kd-11 kd-11 deleted the kd-11:prog_constants_fix branch Feb 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.