Fixup GCM unmap event sending#16273
Merged
Merged
Conversation
elad335
force-pushed
the
lv2
branch
2 times, most recently
from
709f65b to
1caf8c6
Compare
It was reading s_min_tsc again inside the atomic operation. Also optimize it a bit.
Megamouse
reviewed
Nov 2, 2024
|
|
||
| connect(welcome, &QDialog::accepted, this, [&]() | ||
| { | ||
| use_dark_theme = welcome->does_user_want_dark_theme(); |
Contributor
There was a problem hiding this comment.
Why use this strange spaghetti bool instead of just putting the SetValue here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #16272 (comment)
Fixes #16278