Progress Dialog: Fix recursion and concurrency use of text updates#16321
Merged
Conversation
elad335
commented
Nov 15, 2024
elad335
commented
Contributor
- Fix use-after-free of m_text.c_str() by system_progress_dialog after the object of scoped_progress_dialog is freed.
elad335
force-pushed
the
warn-fix
branch
8 times, most recently
from
63c97fa to
488f960
Compare
elad335
force-pushed
the
warn-fix
branch
2 times, most recently
from
bc8a708 to
c17dc09
Compare
Megamouse
reviewed
Nov 15, 2024
Megamouse
reviewed
Nov 15, 2024
Megamouse
reviewed
Nov 16, 2024
Megamouse
reviewed
Nov 16, 2024
elad335
force-pushed
the
warn-fix
branch
2 times, most recently
from
21e803b to
880f58d
Compare
Add assert for sane index access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.