Progress: Dialog: Fixup memory management#16327
Merged
Merged
Conversation
elad335
force-pushed
the
warn-fix
branch
4 times, most recently
from
c814909 to
f966c21
Compare
Megamouse
reviewed
Nov 16, 2024
|
|
||
| for (u64 i = queue_size - 1;; i--) | ||
| { | ||
| if (i == umax) |
Contributor
There was a problem hiding this comment.
Use this as exit condition of for loop. Then break in the scope below.
Return text after the for loop. Less spaghetti
elad335
force-pushed
the
warn-fix
branch
3 times, most recently
from
df651f5 to
26bab1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.