Migrate Savestates Home Menu#16340
Merged
Merged
Conversation
Create necessary files to move the savestates overlay functions to a new subpage in preparation for slots.
QT 6.8.0 doesn't include an msvc 2019 option. So to keep up with the latest trends update the building.md links and examples to msvc 2022.
Revert a change I made that did not work as intended. https://github.com/RPCS3/rpcs3/pull/14836/files#r1520577389
Megamouse
reviewed
Nov 23, 2024
|
|
||
| #include "overlay_home_menu_page.h" | ||
| #include "overlay_home_menu_settings.h" | ||
| #include "overlay_home_menu_savestate.h" |
Contributor
There was a problem hiding this comment.
Why is this included here?
Contributor
Author
There was a problem hiding this comment.
I saw settings.h and thought that would be the best place for savestate.h for the build to compile. else I get
3>C:\Users\bryso\Documents\GitHub\rpcs3\rpcs3\Emu\RSX\Overlays\HomeMenu\overlay_home_menu_main_menu.cpp(76,30): error C2065: 'home_menu_savestate': undeclared identifier
3>(compiling source file '/Emu/RSX/Overlays/HomeMenu/overlay_home_menu_main_menu.cpp')
3>C:\Users\bryso\Documents\GitHub\rpcs3\rpcs3\Emu\RSX\Overlays\HomeMenu\overlay_home_menu_main_menu.cpp(76,18): error C2672: 'std::make_shared': no matching overloaded function found
3>(compiling source file '/Emu/RSX/Overlays/HomeMenu/overlay_home_menu_main_menu.cpp')
3> C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34604\include\memory(2959,44):
3> could be 'std::shared_ptr<_Ty> std::make_shared(const remove_extent<_Ty>::type &)'
3> C:\Users\bryso\Documents\GitHub\rpcs3\rpcs3\Emu\RSX\Overlays\HomeMenu\overlay_home_menu_main_menu.cpp(76,30):
3> 'std::make_shared': invalid template argument for '_Ty', type expected
3> C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34604\include\memory(2950,44):
3> or 'std::shared_ptr<_Ty> std::make_shared(void)'
3> C:\Users\bryso\Documents\GitHub\rpcs3\rpcs3\Emu\RSX\Overlays\HomeMenu\overlay_home_menu_main_menu.cpp(76,30):
3> 'std::make_shared': invalid template argument for '_Ty', type expected
3> C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34604\include\memory(2945,44):
3> or 'std::shared_ptr<_Ty> std::make_shared(const size_t,const remove_extent<_Ty>::type &)'
3> C:\Users\bryso\Documents\GitHub\rpcs3\rpcs3\Emu\RSX\Overlays\HomeMenu\overlay_home_menu_main_menu.cpp(76,30):
3> 'std::make_shared': invalid template argument for '_Ty', type expected
3> C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34604\include\memory(2940,44):
3> or 'std::shared_ptr<_Ty> std::make_shared(const size_t)'
3> C:\Users\bryso\Documents\GitHub\rpcs3\rpcs3\Emu\RSX\Overlays\HomeMenu\overlay_home_menu_main_menu.cpp(76,30):
3> 'std::make_shared': invalid template argument for '_Ty', type expected
3> C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.43.34604\include\memory(2903,44):
3> or 'std::shared_ptr<_Ty> std::make_shared(_Types ...)'
3> C:\Users\bryso\Documents\GitHub\rpcs3\rpcs3\Emu\RSX\Overlays\HomeMenu\overlay_home_menu_main_menu.cpp(76,30):
3> 'std::make_shared': invalid template argument for '_Ty', type expected
3>Done building project "emucore.vcxproj" -- FAILED.
Contributor
There was a problem hiding this comment.
Obviously you have to include it in the cpp, not the h.
You can probably also move the settings.h
Contributor
Author
There was a problem hiding this comment.
Done moved both the settings.h and savestate.h to the .cpp
The Orange Box has 5 games, but ps3 ver is not so good. |
Xcedf
pushed a commit
to Xcedf/rpcs3
that referenced
this pull request
Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for Savestate Slots move all the current code to a subpage of Savestates
Functionality remains intact, Just simply moving the current code to a dedicated file and creating a new page then applying the layout inside of the new page.
Also a misc change with building.md to update the information to msvc2022 instead of 2019 post QT 6.8.0 merge.
Another misc change I was saving for a bigger PR like this to revert a bad decision that didn't work.
The thought about future functionality to add coming soon is Savestate Slot 1, Savestate Slot 2, and Savestate Slot 3. Then Reload Savestate Slot 1, Reload Savestate Slot 2, and Reload Savestate Slot 3.
Why 3 slots?
All the games I have observed have up to 3 games. Kingdom Hearts launchers have 2 games + 1 cinema, Sly Cooper trilogy has 3 games, Devil May Cry HD Collection has 3 games. If anybody has any feedback about a game that has 4 or more games in its launcher please let me know. Journey Collector's Edition doesn't count because the games are installed individually into RPCS3 and can be launched separately without issue.