Skip to content

CELL: Rewrite reservation notification postponing#16361

Merged
elad335 merged 2 commits intoRPCS3:masterfrom
elad335:events
Nov 30, 2024
Merged

CELL: Rewrite reservation notification postponing#16361
elad335 merged 2 commits intoRPCS3:masterfrom
elad335:events

Conversation

@elad335
Copy link
Contributor

@elad335 elad335 commented Nov 30, 2024 •
edited
Loading

  1. Do not postpone reservation notification if there is more than one SPU waiter on this reservation, potentially resulting in a loss of CPU time.
  2. Do not use local reservation time to check for notification redundancy, this was a bug as other thread may walk through the same path of updating reservation then postponing notification then no notification is made at all.
  3. Notify SPU waiters while the PPU itself is idle.

May fix or aid with #16360

@elad335 elad335 added CPU Optimization Optimizes existing code labels Nov 30, 2024
@elad335 elad335 mentioned this pull request Nov 30, 2024
Closed
@elad335 elad335 force-pushed the events branch 4 times, most recently from 896bf35 to 7ab1208 Compare November 30, 2024 10:20
@elad335 elad335 merged commit b450560 into RPCS3:master Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CPU Optimization Optimizes existing code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@elad335