Improved welcome dialog - #16378
Merged
Merged
Conversation
Megamouse
reviewed
Dec 7, 2024
Megamouse
reviewed
Dec 7, 2024
Megamouse
reviewed
Dec 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of #16373 according to some received feedbacks
IMPROVEMENTS:
initial welcome: at application startup, a dialog asking to accept or reject RPCS3's usage conditions is provided. In case the reject button (Exit) is pressed, the application is gracefully terminated. Accept button (Continue) is enabled only if the agreement checkbox (I have read the Quickstart guide) is checkedstandard welcome: welcome dialog opened fromHelpmenu will show only main info and applicable settings. Dark theme, reject button and agreement checkbox are not providedBUGFIXES:
main_window::SaveWindowState()method in case thegui_application::Init()method failed (falsewas returned) to initialize some modules leaving other modules uninitialized (NULL pointed).Initial Welcome dialog:
Standard Welcome dialog: