Skip to content

Yet to fix savestates#16456

Merged
elad335 merged 4 commits into
RPCS3:masterfrom
elad335:events
Dec 27, 2024
Merged

Yet to fix savestates#16456
elad335 merged 4 commits into
RPCS3:masterfrom
elad335:events

Conversation

@elad335

@elad335 elad335 commented Dec 25, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@elad335 elad335 added Bugfix Savestates Anything that involves savestates labels Dec 25, 2024
Megamouse
Megamouse reviewed Dec 25, 2024
View reviewed changes
Comment thread rpcs3/util/serialization.hpp Outdated
Comment thread rpcs3/util/serialization.hpp
Comment thread rpcs3/util/serialization.hpp Outdated
Megamouse
Megamouse reviewed Dec 25, 2024
View reviewed changes
Comment thread rpcs3/Emu/Cell/Modules/cellGem.cpp
@elad335 elad335 force-pushed the events branch 2 times, most recently from 78cef2b to 0b4e9af Compare December 25, 2024 09:38
@elad335 elad335 force-pushed the events branch 2 times, most recently from f0b3578 to 19a7d7a Compare December 25, 2024 11:04
@Darkhost1999

This comment was marked as resolved.

Sign in to view
@elad335

elad335 commented Dec 25, 2024

Copy link
Copy Markdown
Contributor Author

@Darkhost1999 it's not meant for already broken saves, only for newer saves.

@Darkhost1999

Darkhost1999 commented Dec 25, 2024

Copy link
Copy Markdown
Contributor

I clicked save state to create a state. But I'll clean the output folder just in case

@elad335 elad335 force-pushed the events branch 3 times, most recently from a4cb861 to 8fd5aff Compare December 25, 2024 11:58
Megamouse
Megamouse reviewed Dec 25, 2024
View reviewed changes
Comment thread rpcs3/util/serialization.hpp

usz trunc(usz count)
{
data.resize(data.size() - count);

@Megamouse Megamouse Dec 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why no clamp here?

@Darkhost1999

Darkhost1999 commented Dec 25, 2024

Copy link
Copy Markdown
Contributor

The error has changed

E SYS: SPU thread continued after being paused. (old_pc=0x11a8, pc=0xcf4, unsavable=1)
F {Emu State Capture Thread: ''} SIG: Thread terminated due to fatal error: Verification failed (object: 0x0)
(in file D:\a\1\s\rpcs3\Emu\Cell\Modules\cellSysutil.cpp:119[:3], in function 'void sysutil_cb_manager::save(utils::serial &)')
E SYS: Saving savestate failed due to fatal error!

RPCS3.log
I tried Dark Void, Lego Harry Potter, and Bioshock

@elad335 elad335 changed the title Fix savestates Yet to fix savestates Dec 27, 2024
@elad335 elad335 merged commit 7a4e88c into RPCS3:master Dec 27, 2024
@Apopoy

Apopoy commented Dec 28, 2024

Copy link
Copy Markdown

This update still not fix in wwe 2k14 referee still have bugs issue even I already turned on Write buffers
1
RPCS3.log.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Megamouse Megamouse Megamouse left review comments

Assignees

No one assigned

Labels

Bugfix Savestates Anything that involves savestates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elad335 @Darkhost1999 @Apopoy @Megamouse