Skip to content

vk: Support panvk, allow creating device without textureCompressionBC#16490

Merged
elad335 merged 3 commits into
RPCS3:masterfrom
q4a:panvk
Jan 4, 2025
Merged

vk: Support panvk, allow creating device without textureCompressionBC#16490
elad335 merged 3 commits into
RPCS3:masterfrom
q4a:panvk

Conversation

@q4a

@q4a q4a commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

panvk supports BC1-BC3 which is RPCS3 we require, support is reported as false since not all formats are supported

Based on #15978
Tested on Rock 5B SBC (rk3588 SoC, Mali-G610 GPU), Linux 6.12.1, Mesa 25.0~git2501010600.c21bc6

q4a added 2 commits January 1, 2025 22:25
panvk supports BC1-BC3 which is all RPCS3 require, support is reported as
false since not all formats are supported
@kd-11

kd-11 commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

Could you also upload a sample log file?

@q4a

q4a commented Jan 2, 2025

Copy link
Copy Markdown
Contributor Author

@kd-11 this is log after applying my changes (I can start game and it works until crash):
RPCS3.zip

@q4a

q4a commented Jan 3, 2025

Copy link
Copy Markdown
Contributor Author

I can share log of working game (if you need):
RPCS3.log
RPCS3.log.gz

@ginkage

ginkage commented Jan 4, 2025

Copy link
Copy Markdown
Contributor

I had success with running RPCS3 on similar hardware (also rk3588), but with libmali blobs. That also required a similar patch, so it would be nice to make it somewhat more generic.
Log file for reference (same game).
RPCS3.log.gz

@kd-11

kd-11 commented Jan 4, 2025

Copy link
Copy Markdown
Contributor

Compliant drivers don't need the whitelist. It's just these incomplete drivers that need the whitelisting.
I'll merge this PR as-is then maybe we can relax the texture compression check. A permanent fix would require a maintenance extension to allow querying BC support individually for BC1-BC3.

@elad335 elad335 merged commit c9d39ce into RPCS3:master Jan 4, 2025
@q4a q4a deleted the panvk branch January 4, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants