Skip to content

windows: move config.yml and games.yml to /config/, move log files to /log#16494

Merged
Megamouse merged 4 commits into
RPCS3:masterfrom
Megamouse:idm_remove
Jan 16, 2025
Merged

windows: move config.yml and games.yml to /config/, move log files to /log#16494
Megamouse merged 4 commits into
RPCS3:masterfrom
Megamouse:idm_remove

Conversation

@Megamouse

@Megamouse Megamouse commented Jan 2, 2025

Copy link
Copy Markdown
Contributor
  • Moves games.yml to /config
  • Moves config.yml to /config
  • Moves log files to /log
  • Simplifies a bunch of #ifdef _WIN32 code

This moves the old file to the new location if there isn't a file already.

fixes #16478

@Megamouse

Copy link
Copy Markdown
Contributor Author

I've added the code for the log move.
It needs to be discussed by staff whether or not this should get merged.

@digant73

digant73 commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

is the lock file RPCS3.buf related to log file? if so, it seems not moved on log folder

@Megamouse

Copy link
Copy Markdown
Contributor Author

No, why would it?

@digant73

digant73 commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

No, it doesn't need to be moved to log folder if it is not related to log. Just asked to understand which module is using RPCS3.buf. If it is a lock file for the executable then (IMO) it is ok to leave it there

@Megamouse Megamouse changed the title windows: move config.yml and games.yml to /config/ windows: move config.yml and games.yml to /config/, move log files to /log Jan 2, 2025
@schm1dtmac

Copy link
Copy Markdown
Contributor

Any reason why this rearrangement is Windows-only, other than I guess the fact that RPCS3 binaries and configs on windows are all stored together in one loose folder unlike macOS/Linux/etc?

@Megamouse

Copy link
Copy Markdown
Contributor Author

Because on other OSs there already exists a specified config folder.

@Megamouse Megamouse merged commit a7edfa2 into RPCS3:master Jan 16, 2025
@Megamouse Megamouse deleted the idm_remove branch January 16, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Move "config.yml" and "games.yml" under the already existing and used "config" folder

3 participants