Skip to content

sys_time.cpp: Anti TSC measures#16499

Merged
elad335 merged 1 commit into
masterfrom
elad335-patch-1
Jan 3, 2025
Merged

sys_time.cpp: Anti TSC measures#16499
elad335 merged 1 commit into
masterfrom
elad335-patch-1

Conversation

@elad335

@elad335 elad335 commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Fixes #16382

@digant73

digant73 commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

in the first implementation (old PR) you used:

#if is_u128_emulated

in many files but then, in other fixes/improvements, you removed the definition of is_u128_emulated and replaced the above #if with:

#ifdef _MSC_VER

but you forgot the replacement in asm.hpp (at line 413).
Is that something you really missed (so it could be fixed in this PR) or is it what you wanted?

@elad335

elad335 commented Jan 3, 2025

Copy link
Copy Markdown
Contributor Author

it's not related to what I am targeting with this pr. This pr purely reverts TSC reads for time measurements.

@digant73

digant73 commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

I understand, just a feedback about something possibly to review in a proper PR

@elad335

elad335 commented Jan 3, 2025

Copy link
Copy Markdown
Contributor Author

It doesn't fix the savestate issue here and I think there is an open issue about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression] Performance regression since v0.0.33-17061-af052b06

2 participants