PPU LLVM: Function table dependent resolver hashing#16522
Merged
elad335 merged 1 commit intoRPCS3:masterfrom Jan 7, 2025
Merged
PPU LLVM: Function table dependent resolver hashing#16522elad335 merged 1 commit intoRPCS3:masterfrom
elad335 merged 1 commit intoRPCS3:masterfrom
Conversation
elad335
force-pushed
the
func-hash
branch
3 times, most recently
from
552302c to
e8db6dd
Compare
|
RPCS3 crashes after splash screen of Demon's Souls with this update. (Going back to #16500 works again.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symbol resolver function is located on the last PPU module. Previously, its hash was dependent on its hosting module code alone. This led to potential misses of PPU code flow changes in other modules.
Include all the PPU function table addresses when hashing the last module for it.
Fixes #16517