rsx: Fix shader cache loading#16568
Merged
Merged
Conversation
This was referenced Jan 15, 2025
[Regression] Rock Band 3 [BLUS30463] and [BLES00986] - Incorrect Write Color Buffers Behavior
#16562
Closed
Contributor
|
it is working properly now. Tested only with Async mode at the moment. Compiled shaders the first time and then (playing again the same section) rarely compiled shaders. |
|
Testing Rock Band 3 right now and shader compiling is working nicely! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct shaders are cached but the broken loading makes it so that most shaders will fail the comparison later and force a recompilation anyway.
Closes #16565
Closes #16562