cmake: fix build after 3rdparty updates#16574
Merged
Merged
Conversation
Megamouse
added
the
Build and CI
Contributor
Author
|
ping |
hcorion
approved these changes
Feb 15, 2025
hcorion
reviewed
Feb 15, 2025
| IPC_socket.cpp | ||
| ) | ||
|
|
||
| set_target_properties(rpcs3_emu PROPERTIES INTERPROCEDURAL_OPTIMIZATION $<$<CONFIG:Release>:TRUE>) |
Member
There was a problem hiding this comment.
Suggested change
| set_target_properties(rpcs3_emu PROPERTIES INTERPROCEDURAL_OPTIMIZATION $<$<CONFIG:Release>:TRUE>) | |
| set_target_properties(rpcs3_emu PROPERTIES INTERPROCEDURAL_OPTIMIZATION $<$<OR:$<CONFIG:Release>,$<CONFIG:RelWithDebInfo>,$<CONFIG:MinSizeRel>>:TRUE>) |
Contributor
Author
There was a problem hiding this comment.
After testing I discovered that generator expressions don't work for INTERPROCEDURAL_OPTIMIZATION. I just introduced an option to turn it off, because debug configurations like Debug and RelWithDebInfo do not work with LTO.
hcorion
approved these changes
Feb 15, 2025
Contributor
|
@oltolm which MS C++ redistributable version are you using? |
Contributor
Author
|
I don't know. I just installed the VS2022 17.13.0. |
Contributor
|
@oltolm Hey, consider joining the discord server if you haven't already. There's a development channel with all the project contributors. |
Contributor
Author
|
@Yahfz I have already joined the discord server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of CMake problems. MSVC CMake build did not work, building on Windows with internal zlib also did not work.