Skip to content

rsx: Shader interpreter improvements#16576

Merged
kd-11 merged 3 commits into
RPCS3:masterfrom
kd-11:rsx-volatile
Jan 19, 2025
Merged

rsx: Shader interpreter improvements#16576
kd-11 merged 3 commits into
RPCS3:masterfrom
kd-11:rsx-volatile

Conversation

@kd-11

@kd-11 kd-11 commented Jan 18, 2025

Copy link
Copy Markdown
Contributor
  1. Reworks descriptor binding layout so that we can reuse the same code for both main RSX shaders and the interpreter.
  2. Fixes a texturing regression in the interpreter that caused most textures to be black.

Closes #16374

@digant73

digant73 commented Jan 19, 2025

Copy link
Copy Markdown
Contributor

In case it is a bug (present also on old releases), in some games such as R1, R2, UC1 etc. with Vulkan renderer, Shader Interpreter only shader and Anti-Aliasing set to Auto in the GPU tab I have something like:

image

while if Anti-Aliasing is set to Disabled I have a proper image:

image

I also see that R3 immediately crashes with device lost (with both Auto or Disabled) on loading the selected chapter (black screen and freeze with device-lost logged in the GUI). Maybe it could be reproducible on your env

@kd-11

kd-11 commented Jan 19, 2025

Copy link
Copy Markdown
Contributor Author

Turns out we don't support MSAA sampling at all for the interpreter. Instead of rushing to add it in, I've created a separate tracker for it here: #16584

@kd-11

kd-11 commented Jan 19, 2025

Copy link
Copy Markdown
Contributor Author

Resistance 3 crash is caused by a GPU hang which means broken flow control. That needs to be investigated separately.

@kd-11 kd-11 merged commit 2af497e into RPCS3:master Jan 19, 2025
@digant73

Copy link
Copy Markdown
Contributor

Resistance 3 crash is caused by a GPU hang which means broken flow control. That needs to be investigated separately.

yeah, just provided a possible example (I found it testing the interpreter shader) to reproduce the issue in your env to troubleshoot the device-lost issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shader interpreter causing a crash on AMD GPU

3 participants