cellPad: Disconnect and reconnect the controller when the device type is changed#16596
Merged
Conversation
sanjay900
changed the title
sanjay900
force-pushed
the
support-device-change
branch
from
b653948 to
9e29ef5
Compare
sanjay900
force-pushed
the
support-device-change
branch
from
9e29ef5 to
f8bc539
Compare
sanjay900
changed the title
sanjay900
changed the title
sanjay900
force-pushed
the
support-device-change
branch
from
f8bc539 to
153b014
Compare
sanjay900
changed the title
sanjay900
force-pushed
the
support-device-change
branch
from
153b014 to
4fce44f
Compare
Megamouse
reviewed
Jan 22, 2025
sanjay900
force-pushed
the
support-device-change
branch
3 times, most recently
from
fafe249 to
aed2639
Compare
sanjay900
changed the title
sanjay900
force-pushed
the
support-device-change
branch
from
aed2639 to
dbb4942
Compare
sanjay900
changed the title
Megamouse
reviewed
Jan 22, 2025
Megamouse
reviewed
Jan 22, 2025
sanjay900
force-pushed
the
support-device-change
branch
from
e1ad584 to
9072a03
Compare
Contributor
|
@sanjay900 it could be nice if you could have a look to this bug #14063 (or #16445 reporting easy steps to reproduce the issue) related to RPCS3 crash after some time the pad is disconnected (e.g. for inactivity). Maybe it is also a bug on RPCS3 that could be fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Games expect a disconnection and reconnection when a controllers device type changes, since normally that would require physically unplugging the controller and swapping it for a new one.
Ive made it so that if the device class, vid or pid changes, then a timer is started and the controllers is disconnected until the timer expires, to simulate the controller being disconnected.