SPU LLVM: Replace xorsum with simple checksum#16651
Merged
elad335 merged 1 commit intoRPCS3:masterfrom Feb 1, 2025
Merged
Conversation
- Fixes crashes in GTAV
Contributor
|
Fixes crash regression in GTA V. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a stupid simple checksum instead of the xorsum for spu verification. The xorsum has issues with repeating data.
This fixes crashes in GTAV.
Please test other games.
Fixes: #16647
Note: Might be slightly slower for 512b machines for now, a future PR will add 2 dependency chains to fix this issue, if the checksum works well.