cellGemPrepareCamera: reduce cellCamera log spam by setting some camera features#16662
Merged
Conversation
Megamouse
force-pushed
the
cellGemPrepare
branch
from
65f0d62 to
136511f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces a lot of cellGemPrepareCamera spam in combination with cellCameraGetAttribute in LBP3.
The game calls cellGemPrepareCamera and checks with cellCameraGetAttribute if one of the attributes is disabled.
The game repeats this indefinitely if the attribute is not disabled as expected.
I don't know if this improves performance or if this fixes any other camera issues in the game.