cellL10n: implement SBCS conversions

[Megamouse]

No description provided.

[Darkhost1999]

U cellL10n TODO: UCS2stoSBCSs(src=*0x3200d098, src_len=*0xd00106e0, dst=*0x302cb880, dst_len=*0xd00106e4, code_page=*0x1d)
Did you mean notice instead of todo?
RPCS3.log
Works great in Oblivion.

[Megamouse]

I don't even know what it looks like on master

[Darkhost1999]

PR
cellL10n: UCS2stoSBCSs(src=*0x3200d098, src_len=*0xd00106e0, dst=*0x302ca878, dst_len=*0xd00106e4, code_page=*0x1d)
RPCS3.log
Master
cellL10n TODO: UCS2stoSBCSs()
RPCS3.log
Still works just informing

[Megamouse]

I obviously mean the game, not the log message

[Darkhost1999]

Well, it just says <- Enter Character Name ->
And after entering the name doesn't change.
So with the conversion working now, you can name your character.

The same as the last cellL10n PR from " " to " text "

[elad335]

Why is this module not LLEd?

[elad335]

Ok, It is LLEd. please refrain from implementing more functions of this module. This is a dump of Ghidra without an actual value.
It can only inflate our codebase and increase compilation time for little to no benefit.

[Megamouse]

stop talking nonsense

[elad335]

How is this nonsense?

[Megamouse]

It's nonsense because you are complaining about implementing things.
Which is all we do every day.

[elad335]

there are 153 unimplemented functions in this module, around 60 lines for each function to implement I assume. That's more than 9000+ lines in one file for a module that should be LLEd.

[Megamouse]

then that's 9000+ lines of fun yet to have

[elad335]

That is insane and Emu/Cell/Module does take a long time to compile. It is full of modules are not used anymore. Some even are embedded in game code and cannot be LLEd.
If you want to have fun then do it on your fork, don't involve the main codebase for this.

[Megamouse]

I'm not complaining about your spaghetti code either, yet here we are

[elad335]

The code here looks like this:

if (static_cast<s8>(src_val) < '\0')

If you want to implement these functions, at least make it readable.

It's also technically bug, char is not defined to be signed or unsigned by c++.

[oltolm]

C:/src/rpcs3/rpcs3/Emu/Cell/Modules/cellL10n.cpp:2505:12: warning: result of comparison of constant 65534 with expression of type 'const s16' (aka 'const short') is always false [-Wtautological-constant-out-of-range-compare]
 2505 |                 if (ucs2 >= 0xfffe)
      |                     ~~~~ ^  ~~~~~~
1 warning generated.