Merged
Conversation
Megamouse
added
the
Build and CI
kd-11
reviewed
Feb 11, 2025
3rdparty/CMakeLists.txt
Outdated
|
|
||
|
|
||
| # Vulkan | ||
| # SPIRV |
Contributor
Author
There was a problem hiding this comment.
Changed it to simply 'glslang'.
kd-11
approved these changes
Feb 11, 2025
Contributor
kd-11
left a comment
kd-11
left a comment
There was a problem hiding this comment.
lgtm, but fix that comment change
Since commit 4594c91 made SPIRV required dependency, it needs to be linked in CMakeLists.txt regardless of USE_VULKAN.
pastalian
force-pushed
the
fix-build-wihout-vulkan
branch
from
208101b to
b787cf8
Compare
kd-11
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit 4594c91 made SPIRV required dependency, it needs to be linked in CMakeLists.txt regardless of USE_VULKAN.
Downstream Bug: https://bugs.gentoo.org/949579