Skip to content

CI: Use windows-2025 Runner#16731

Merged
elad335 merged 2 commits into
RPCS3:masterfrom
Xphalnos:patch-1
Feb 20, 2025
Merged

CI: Use windows-2025 Runner#16731
elad335 merged 2 commits into
RPCS3:masterfrom
Xphalnos:patch-1

Conversation

@Xphalnos
Copy link
Copy Markdown
Contributor

windows-latest defaults to windows-2022 runner, the benefits of updating the runner are to be able to use newer packages like the Windows SDK.

  • windows-2022 = 10.0.20348
  • windows-2025 = 10.0.26100

@illusionyy
Copy link
Copy Markdown
Contributor

Wouldn't it be updated by newer images in the future anyways?

@Darkhost1999
Copy link
Copy Markdown
Contributor

Darkhost1999 commented Feb 20, 2025

The -latest migration process is gradual and happens over 1-2 months.
https://github.com/actions/runner-images/blob/main/README.md

Since 2025 was just 9 days ago we can just have patience waiting for the migration process to reach our workflow and it'll update itself.

@elad335
Copy link
Copy Markdown
Contributor

elad335 commented Feb 20, 2025

Maybe it is better to make it hardcoded. 🤷‍♂️

@Xphalnos
Copy link
Copy Markdown
Contributor Author

Maybe it is better to make it hardcoded. 🤷‍♂️

What do you mean by hardcoded? Add a dependency that allows us to use windows-2025?

@elad335
Copy link
Copy Markdown
Contributor

elad335 commented Feb 20, 2025

No I mean, simply specifying the exact value. (as it is by this pr)

@elad335 elad335 merged commit 26e0f56 into RPCS3:master Feb 20, 2025
@Xphalnos Xphalnos deleted the patch-1 branch February 20, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants