GL: front face regression fix #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raven02 Can you get your hands on a demo with face culling? I'm almost certain the same should be done for vk and dx12 (vertex winding is reversed when shader origin is bottom left, which is what rpcs3 supports at the moment) |
|
Probably need to check out which current gcm sample/game title uses the face culling and compare against different backend . |
raven02
pushed a commit
that referenced
this pull request
Jul 3, 2016
* Vulkan/DX12 : refactor cull face code 1 * Add optimal build options to CMakeLists (#1841) Provides two options when building RPCS3 USE_SYSTEM_FFMPEG BOOL (default: OFF) USE_SYSTEM_LIBPNG BOOL (default: OFF) These options lets the user select between the system provided and builtin libraries of ffmpeg and libpng to overcome possible system issues. Also adds support for older libpng releases if the user doesn't have libpng 1.5 or higher. * DX12: depth buffer compare should perform only if depth testing is enabled (#1848) * GL: front face regression fix (#1854) * GUI: Add bulk decryption of LLE modules (#1845) Adds a new menu to "Tools" called "&Decrypt SPRX libraries" which opens a dialog to select multiple *.sprx files, which are than decrypted all at once. This speeds up the LLE module decryption and saves users a lot of time. The output path is the same where the input module resides and the extension is changed to *.prx * vk: Avoid double-copy for vertex attributes (#1852) * vk: Avoid double-copy for vertex attributes fix buffer overflow vk: Fix vertex attrib offset_in_dst for batched draw calls * whitespace fix only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.