New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nv3089_image_in #2405

Merged
merged 1 commit into from Feb 18, 2017

Conversation

Projects
None yet
8 participants
@jarveson
Contributor

jarveson commented Feb 18, 2017

The main changes are:

  • To restrict the clip y/x to (in_x/y + in_w - 1) as per docs
  • Remove double addition of out_offset when clipping/converting

Also rearranged a bit to get some things as const to make the function a bit easier to work with.

This makes #2166 create the correct shaders now and looks a bit better, as cg loader uses image_in to blit the shaders to rsx memory, and gave some invalid clip values

Fix nv3089_image_in
- Restrict clip_x/y
- Remove double offset addition
@mention-bot

This comment has been minimized.

mention-bot commented Feb 18, 2017

@jarveson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kd-11, @vlj and @Nekotekina to be potential reviewers.

@aakh1361

This comment has been minimized.

aakh1361 commented Feb 18, 2017

is This Fix only DX12 ?

@jarveson

This comment has been minimized.

Contributor

jarveson commented Feb 18, 2017

No, it would be all of them, and possibly any game/app that uses this function

@ScorchEmber256

This comment has been minimized.

ScorchEmber256 commented Feb 18, 2017

No longer a black screen :)
fixed

@SakataGintokiYT

This comment has been minimized.

Contributor

SakataGintokiYT commented Feb 18, 2017

@jarveson
Fotoszok.pl
Fotoszok.pl

@kd-11

This comment has been minimized.

Contributor

kd-11 commented Feb 18, 2017

@jarveson I was looking into this as well since it interacts with buffer synchronization. Might I ask which references you used for this? I was still looking around for good docs on the chip.
Since image_in downloads images from rendered targets at times, but does not scale them, I was wondering if image rescaling is actually necessary when downloading render targets. I guess more tests will be needed.

@SakataGintokiYT Does this PR fix games like Bakugan as well? Or do those still show a black screen?

@SakataGintokiYT

This comment has been minimized.

Contributor

SakataGintokiYT commented Feb 18, 2017

@kd-11
Still black screen

@kd-11

This comment has been minimized.

Contributor

kd-11 commented Feb 18, 2017

Oh. Ok then. Can be merged as soon as we know there aren't any regressions.

@SakataGintokiYT

This comment has been minimized.

Contributor

SakataGintokiYT commented Feb 18, 2017

@kd-11
I don't found any regression

@kd-11 kd-11 merged commit 22c0f0d into RPCS3:master Feb 18, 2017

2 of 3 checks passed

code-review/pullapprove Approval required by 1 of: Nekotekina, raven02, vlj
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jarveson jarveson deleted the jarveson:imagein-fix branch Feb 18, 2017

@jarveson

This comment has been minimized.

Contributor

jarveson commented Feb 18, 2017

Cool to hear its fixing other things.

But @kd-11 , i haven't found really anything besides whats in the sdk, which is pretty sparse, so im not sure about your scaling question unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment