Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cell/rsx: Bug Fixes #2962

Merged
merged 8 commits into from Jul 8, 2017

Conversation

Projects
None yet
10 participants
@kd-11
Copy link
Contributor

commented Jul 6, 2017

  • Implement frame skipping (config file option only for now)
  • WIP: Batch together draw calls using the same geometry with different translation matrices
  • Allow multithreaded vertex processing
  • Fix some fragment shader instructions
  • Implement rsx framebuffer memory persistence
  • Fix vulkan layout transitions
  • Properly implement FCGT and FCMGT SPU opcodes
  • Minor tweaks to SPU wait loops and DMA transfers to improve stalling behaviour

Major highlights

  • Fixes persona 5 and many other games with blue output and 'overbloom'
  • Fixes missing characters in Red Dead Redemption
  • Fixes most of the missing graphics is Tales of Vesperia
  • Fixes flickering graphics when using vulkan in some games
@mention-bot

This comment has been minimized.

Copy link

commented Jul 6, 2017

@kd-11, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Nekotekina, @vlj and @hcorion to be potential reviewers.

@OverlordCW

This comment has been minimized.

Copy link

commented Jul 6, 2017

I got this once in RDR with Vulkan:
F {rsx::thread} class std::runtime_error thrown: Working buffer not big enough, buffer_length=268435456 allocated=266515712 requested=1048576 guard=65536 largest_pool=1048576
(in file c:\rpcs3\rpcs3\emu\rsx\d3d12../Common/ring_buffer_helper.h:74)

@Luffykun007

This comment has been minimized.

Copy link

commented Jul 6, 2017

Before
capturar1

AFTER
capturar

@AniLeo

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2017

This PR fixes the corrupted Skybox in Naruto: Ultimate Ninja Storm.

@Xcedf

This comment has been minimized.

Copy link

commented Jul 7, 2017

Luffykun007, VF5 freezing is different error and it has nothing to do with this PR
btw eyes color are also fixed for heavy rain loading cutscenes

@Xcedf

This comment has been minimized.

Copy link

commented Jul 7, 2017

Soul Calibur IV menu colors are fixed

@Xcedf

This comment has been minimized.

Copy link

commented Jul 7, 2017

Pure green filter fixed
22

@SakataGintokiYT

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2017

Dead Space 2
Graphic in game is fixed now but title screen is still broken
Fotoszok.pl

@Zangetsu38

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2017

@twdarkeh

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2017

Fixes the blue haze in Akiba's Trip, but character textures still broken.

@raven02

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2017

Saint Seiya: Sanctuary Battle crashes at title screen using vulkan backend with this pull when compared with master .

This bug happened before and fixed by #2769

@SakataGintokiYT

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2017

Dead Space 1
Graphic in game is fixed now but title screen is still broken
bez tytulu

kd-11 added some commits Jun 25, 2017

rsx: Fix some fp bugs
rsx/fp: Properly fix RCP
- Input is always scalar, output is a vector

rsx/fp: Ignore forced unit for SIP and TEX instructions
rsx: Minor bug fixes
- vk: Do not select first available format when choosing a swapchain format
- gl/vk: Ignore rendering zero sized framebuffers/scissors
- fp: Re-enable range clamp on fp16 registers; fix fx12 clamping [-2, 2]
spu: Reimplement FCGT and FCMGT to handle corner cases (such as compa…
…risons against infinites and denormals)

- Also optimize FMA/FMS/FNMS for recompiler

@kd-11 kd-11 force-pushed the kd-11:master branch from a852e2c to 193b8fe Jul 8, 2017

@kd-11 kd-11 changed the title [WIP] cell/rsx: Bug Fixes cell/rsx: Bug Fixes Jul 8, 2017

@kd-11 kd-11 merged commit 41d9218 into RPCS3:master Jul 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.