New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LLE-GCM #3096

Merged
merged 4 commits into from Aug 1, 2017

Conversation

Projects
None yet
@jarveson
Contributor

jarveson commented Jul 26, 2017

Implements support for lle of GCM.

  • LLE turned to auto / default as major regression seems to be found and fixed
  • HLE still functions as well as it did (with some fixes), but will need to be manually coded out
  • Report any regressions found with lle now
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 26, 2017

@jarveson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Nekotekina, @vlj and @acmiyaguchi to be potential reviewers.

mention-bot commented Jul 26, 2017

@jarveson, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Nekotekina, @vlj and @acmiyaguchi to be potential reviewers.

@Xcedf

This comment has been minimized.

Show comment
Hide comment
@Xcedf

Xcedf Jul 27, 2017

Now this branch even greater after being able to swithch between LLE and HLE gcm, but lle-gcm had some issues and hle also has it now
what kind of issue could this be
27
28
Some other games also has the same
from my list its
SH Downpour
Bulletstorm
Spec Ops The Line
And btw, will be gcm module removed from lv2 ignore list?

Xcedf commented Jul 27, 2017

Now this branch even greater after being able to swithch between LLE and HLE gcm, but lle-gcm had some issues and hle also has it now
what kind of issue could this be
27
28
Some other games also has the same
from my list its
SH Downpour
Bulletstorm
Spec Ops The Line
And btw, will be gcm module removed from lv2 ignore list?

@jarveson jarveson referenced this pull request Jul 27, 2017

Closed

LLE-GCM Regressions #3105

@jarveson

This comment has been minimized.

Show comment
Hide comment
@jarveson

jarveson Jul 27, 2017

Contributor

@Xcedf are these regressions with HLE? For now ive opened issue #3105 to track issues like the ones you've mentioned with lle, although if they happen with HLE now, that changes things

Contributor

jarveson commented Jul 27, 2017

@Xcedf are these regressions with HLE? For now ive opened issue #3105 to track issues like the ones you've mentioned with lle, although if they happen with HLE now, that changes things

@Xcedf

This comment has been minimized.

Show comment
Hide comment
@Xcedf

Xcedf Jul 27, 2017

@jarveson yes, they happen with hle now too

Xcedf commented Jul 27, 2017

@jarveson yes, they happen with hle now too

@jarveson

This comment has been minimized.

Show comment
Hide comment
@jarveson

jarveson Jul 27, 2017

Contributor

Fixed zcull issue which should remove regressions that happened

Contributor

jarveson commented Jul 27, 2017

Fixed zcull issue which should remove regressions that happened

@Xcedf

This comment has been minimized.

Show comment
Hide comment
@Xcedf

Xcedf Jul 27, 2017

Confirm fixed now
28

Xcedf commented Jul 27, 2017

Confirm fixed now
28

@Xcedf

This comment has been minimized.

Show comment
Hide comment
@Xcedf

Xcedf Jul 28, 2017

fixed screen update issue in Metal Gear Revengeance
33

Xcedf commented Jul 28, 2017

fixed screen update issue in Metal Gear Revengeance
33

@AniLeo

This comment has been minimized.

Show comment
Hide comment
@AniLeo

AniLeo Jul 31, 2017

Contributor

Any other regressions? Should be good for merge 🔜 if not

Contributor

AniLeo commented Jul 31, 2017

Any other regressions? Should be good for merge 🔜 if not

@Illynir

This comment has been minimized.

Show comment
Hide comment
@Illynir

Illynir Jul 31, 2017

I don't know if this a regression but in Kingdom Heart 1 on KH 1.5 Remix HD the shadows of characters flicker a little. On master, they aren't flicker at all and are perfect. (With write color buffer else there are no shadows at all on master and LLE GCM)

Then... I don't know if it's because write color buffer in combination with LLE GCM or not or if it's really a regression.

For the rest, no problem to report.

Illynir commented Jul 31, 2017

I don't know if this a regression but in Kingdom Heart 1 on KH 1.5 Remix HD the shadows of characters flicker a little. On master, they aren't flicker at all and are perfect. (With write color buffer else there are no shadows at all on master and LLE GCM)

Then... I don't know if it's because write color buffer in combination with LLE GCM or not or if it's really a regression.

For the rest, no problem to report.

@Igihara

This comment has been minimized.

Show comment
Hide comment
@Igihara

Igihara Jul 31, 2017

Controlled character moves slow when the analog stick is moved diagonally on this build(?) using xinput. Blog build doesn't have that issue.

Igihara commented Jul 31, 2017

Controlled character moves slow when the analog stick is moved diagonally on this build(?) using xinput. Blog build doesn't have that issue.

@AniLeo

This comment has been minimized.

Show comment
Hide comment
@AniLeo

AniLeo Jul 31, 2017

Contributor

This build doesn't touch XInput and the blog build is not a master

Contributor

AniLeo commented Jul 31, 2017

This build doesn't touch XInput and the blog build is not a master

@Inviuz

This comment has been minimized.

Show comment
Hide comment
@Inviuz

Inviuz Jul 31, 2017

Contributor

Probably related to recent xinput changes, try changing Pad Squircling Factor in config_xinput.yml to 4000

Contributor

Inviuz commented Jul 31, 2017

Probably related to recent xinput changes, try changing Pad Squircling Factor in config_xinput.yml to 4000

@fifazalata

This comment has been minimized.

Show comment
Hide comment
@fifazalata

fifazalata Jul 31, 2017

@Igihara If you mean running diagonally in P5, then try changing
Pad Squircling Factor: from 8000 to 4000 in the "config_xinput.yml" file
That should fix the problem.

fifazalata commented Jul 31, 2017

@Igihara If you mean running diagonally in P5, then try changing
Pad Squircling Factor: from 8000 to 4000 in the "config_xinput.yml" file
That should fix the problem.

@Igihara

This comment has been minimized.

Show comment
Hide comment
@Igihara

Igihara Aug 1, 2017

Changing it to 4000 fixed it. Thanks guys.

Igihara commented Aug 1, 2017

Changing it to 4000 fixed it. Thanks guys.

@AniLeo AniLeo requested a review from Nekotekina Aug 1, 2017

@Nekotekina Nekotekina merged commit 02845f5 into RPCS3:master Aug 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jarveson jarveson deleted the jarveson:lle-gcm-pr2 branch Aug 2, 2017

@Kubokoo

This comment has been minimized.

Show comment
Hide comment
@Kubokoo

Kubokoo Aug 2, 2017

In master version with this pull, persona 5 in menus there is some black piece of that covers text.
(RPCS3 v0.0.3-8-b396826 Alpha
Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz | 4 Threads | 15.69 GiB RAM | AVX)

image

In older version (RPCS3 v0.0.3-5587-5b61dcdc Alpha) this problem does not exists.

image

Kubokoo commented Aug 2, 2017

In master version with this pull, persona 5 in menus there is some black piece of that covers text.
(RPCS3 v0.0.3-8-b396826 Alpha
Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz | 4 Threads | 15.69 GiB RAM | AVX)

image

In older version (RPCS3 v0.0.3-5587-5b61dcdc Alpha) this problem does not exists.

image

@jarveson

This comment has been minimized.

Show comment
Hide comment
@jarveson

jarveson Aug 3, 2017

Contributor

try with #3135 @Kubokoo

Contributor

jarveson commented Aug 3, 2017

try with #3135 @Kubokoo

@Kubokoo

This comment has been minimized.

Show comment
Hide comment
@Kubokoo

Kubokoo Aug 3, 2017

On a freshly compiled version (without #3135 ) I got this:

image

With #3135 I got this (there still is some black part, but it does not cover text anymore):

image

Kubokoo commented Aug 3, 2017

On a freshly compiled version (without #3135 ) I got this:

image

With #3135 I got this (there still is some black part, but it does not cover text anymore):

image

@Kravickas

This comment has been minimized.

Show comment
Hide comment
@Kravickas

Kravickas Aug 7, 2017

Contributor

This broke NHL 15 to not rendering anything

I think it cos u deleted

-		/*
-
-		// Store previous fbo addresses to detect RTT config changes.
-		std::array<u32, 4> m_previous_color_address = {};
-		u32 m_previous_address_z = 0;
-		u32 m_previous_target = 0;
-		u32 m_previous_clip_horizontal = 0;
-		u32 m_previous_clip_vertical = 0;
-		*/

2 previous build were getting E {rsx::thread} RSX: FBO check failed: 0x8cd6, but it was rendering game.

Contributor

Kravickas commented Aug 7, 2017

This broke NHL 15 to not rendering anything

I think it cos u deleted

-		/*
-
-		// Store previous fbo addresses to detect RTT config changes.
-		std::array<u32, 4> m_previous_color_address = {};
-		u32 m_previous_address_z = 0;
-		u32 m_previous_target = 0;
-		u32 m_previous_clip_horizontal = 0;
-		u32 m_previous_clip_vertical = 0;
-		*/

2 previous build were getting E {rsx::thread} RSX: FBO check failed: 0x8cd6, but it was rendering game.

@Kravickas Kravickas referenced this pull request Aug 7, 2017

Closed

Regression - NHL 15 #3156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment