New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Qt] fix small buttons/missing icons in the toolbar (Doppelgänger) #3413

Merged
merged 7 commits into from Sep 10, 2017

Conversation

Projects
None yet
6 participants
@Megamouse
Contributor

Megamouse commented Sep 8, 2017

In case you are wondering why I don't use the #else path in windows:
It will basically be too small as long as we use SetProcessDpiAware

I hope Qt fixes the Dpi stuff in one of its next iterations so we can bury that chapter forever

Please try this on ubuntu etc.

@mention-bot

This comment has been minimized.

mention-bot commented Sep 8, 2017

@Megamouse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @flash-fire, @Nekotekina and @AniLeo to be potential reviewers.

@greentop

This comment has been minimized.

greentop commented Sep 9, 2017

The toolbar icons appear to be working correctly in Ubuntu.
(The game list on the left side is my custom layout and is unrelated to this PR.)
rpcs3_ubuntu_16_04_pr3413

@scribam

This comment has been minimized.

Contributor

scribam commented Sep 9, 2017

Works for me. Fix #3279

AniLeo and others added some commits Sep 9, 2017

@Nekotekina Nekotekina merged commit f0358f8 into RPCS3:master Sep 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment