[Qt] graphixes #3441
Merged
[Qt] graphixes #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Megamouse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @flash-fire, @scribam and @kd-11 to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kd-11 noticed some strange behaviour with vulkan adapters not saving.
As I looked into it I found that oldRender was initiated instead of m_oldRender before the first render switch and then never used. So m_oldRender was only ever set after two render switches which also meant saving worked only then.
Then I was annoyed by having to check for every renderer manually so I just went and made it more generalized for any renderers to come (may there ever be more than those we currently have)
I hope I didn't miss anything in the procedure since I'm so tired xD