Debugger improvements #3633
Merged
Debugger improvements #3633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattPryze
changed the title
Marthgun
reviewed
Oct 22, 2017
rpcs3/rpcs3qt/debugger_frame.cpp
Outdated
| @@ -473,9 +493,58 @@ void debugger_frame::EnableButtons(bool enable) | |||
|
|
|||
| void debugger_frame::ClearBreakpoints() | |||
| { | |||
| //deleting the breakpoints here turns this function into an all purpose clear breakpoints instead of just clearing on emu stop | |||
There was a problem hiding this comment.
minor quibble, you have 2 empty lines underneath this comment before the for loop. most of the code base would have no lines, with comment directly above denoted loop.
There was a problem hiding this comment.
Ah. I'll check more carefully next time :)
There was a problem hiding this comment.
Oh I didn't realize that I was the only one that could make the changes. I'm new to github. 1 sec
There was a problem hiding this comment.
Technically I can edit the changeset for you but its better if the author does it themselves. That way, commit history is intact and git blame identifies the authors correctly.
As soon as I tried the debugger, i wanted to move it to the middle almost instantly. Checked the code and found it sitting right here but commented out. Why? This is awesome.
Added a list widget that displays all the currently active breakpoints. You can rename each one for convenience, delete them in bulk, or double click to jump to that address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pull request and first time using github so rip me if I did it wrong.
I repositioned the debugger's current instruction to be in the middle. It used to be at the top so u always had to scroll to see what came before it. Now it's smack dab in the middle.
Added a breakpoints list so you can see all the current breakpoints. That way you can navigate away from them and you dont need to remember them to remove them. Double clicking on a breakpoint entry in the list will automatically load that breakpoint address. You can remove them in bulk by selecting them and pressing Delete. Or you can right click the selection and remove them that way. You can also rename each breakpoint entry for convenience.