rsx: Fixes

[kd-11]

Fixes the remaining regressions with the new texture cache. Also adds a few improvements elsewhere

• Fix clipping bug when using vulkan + gpu texture scaling
• Restructures the texture cache to contain section manipulation to one function
• Fix debug counters for texture cache. Also track texture memory usage
• Fix some leaking memory sections
• Fix surface subsection sampling ("Turbo: Super Stunt Squad)
• Fix crashing due to 0 pitch (VirtualMemory.cpp crash)
• Add buffer names to vulkan heaps to help debug OOM crashes ("Working buffer not enough" crash)
• Better detection of situations that would require memory stitching (framebuffer blit operations). Should fix black screen regressions in some games

[greentop]

Ubuntu 16.04 / Nvidia 387.12 / LLVM 4 / (PR #3638)

RPCS3 GPU Additional Settings:
Enabled - Vulkan / Use GPU Texture Scaling / 16xAF

Game: ToCS2 BLUS31597

Log line: 18769

·F 0:01:10.914775 {rsx::thread} St13runtime_error thrown: Assertion Failed! Vulkan API call failed with unrecoverable error: Out of video memory (VRAM) (VK_ERROR_OUT_OF_DEVICE_MEMORY)
(in file /home/green/rpcs3/rpcs3/Emu/RSX/VK/VKHelpers.h:286)

RPCS3.log.gz

[kd-11]

@greentop What are the texture statistics shown if you enable the debug overlay? Log cant really show leaks. Enable the debugging tab by editing CurrentSettings.ini in GuConfigs and enable Debug Overlay. Or just set it to true in the config file manually

[aakh1361]

old build

this build

[kamer1337]

Tony Hawk's Pro Skater 5 Vulkan:

F {PPU[0x1000017] Thread (RenderingThread) [0x01fe37dc]} class std::runtime_error thrown: Verification failed (e=0x1e7):
(in file ..\Utilities\VirtualMemory.cpp:83)

OpenGL is broken

on videos

[Kravickas]

VirtualMemory.cpp crash seems fixed in NHL 16 and Far cry 2

[Sandvichero]

Nier Replicant [BLJM602223]
Now has far worse framerate and spams this in the log:
E {rsx::thread} RSX: Unsupported RTT scaling factor: dst_pitch=5120 src_pitch=3072

[greentop]

RPCS3.log.gz

The screenshot was taken at the point after the game freezes with the out of video memory error.

[kd-11]

That might be the cause. 157 large textures will easily consume alot of extra VRAM. On vulkan, objects are not released immediately due to frame synchronization, but on openGL they can be released back to the driver. I'll see about balancing the memory tracker for lower end GPUs with smaller memory pools

[Asinin3]

Master (3 Unreleased textures)

PR (476 Unreleased)

[kd-11]

It should be improved now. There was unnecessary thrashing of texture memory due to an overzealous prepare memory blocks. Should also fix the broken bink videos for OpenGL

[greentop]

As of (d865dec)

RPCS3.log.gz
This screenshot was taken after reaching the out of video memory error. (game hanged)
The FPS performance did improve in some of the other title 'start/continue game' screens, to 30fps seen in areas that are not using weather visual effects.

[alex88510]

I'm also playing ToCS2 too but in chinese version (shouldn't matter right?).
I haven't had any freezeing/crashing so far and I am almost half way through the whole game, aside from random texture corruption as before (haven't tested with this PR).

The fps did drop a lot when I reached an area with weather visual effects just like @greentop mentioned.
Like from steady 30fps to 10fps.

I'm using GTX970 with vulkan.
@kd-11 do you need more info from mine?

[kd-11]

Check VRAM usage with this PR to see if its worse.

[alex88510]

I'm not sure if I check it the correct way.
I used my desktop widget to track the vram usage.

On master:


RPCS3_old.log.gz

On this PR:


RPCS3_new.log.gz

P.S.
On idle before the game start, the vram usage is like this.

From what I see, it seems the same.
All screenshots are taken right after the game finished loading the save file.

EDIT:
as of 01b19d3, it seems the vram usage dropped to 712MB and the unreleased texture drop to 22.

[kd-11]

It seems the game is using some large textures if 22 textures can fill 64MB. As long as performance is stable then it should not be too much of an issue. @greentop Any improvement on your end?

[alex88510]

Will this improve the fps on weather effect intensive area(snowing, fog...)? I have yet to try that.

[greentop]

(As of 01b19d3)

RPCS3.log.gz
The above screenshot was taken after encountering the out of video memory error. (game hanged)

For comparison, below is another map area that doesn't have a weather effect present.

Edit:
OpenGL comparison for the same area below. (No game hang for in OpenGL observed.)

RPCS3.log.gz
The low FPS in OpenGL here is likely the result of the 100% GPU usage as observed in the 'Nvidia X Server Settings' control panel. (Other faster GPU's should be seeing better FPS performance for this map area.) Vulkan renderer for the same area though peaks out at 39% GPU usage just before the game hangs with the out of video memory error.

[kd-11]

@alex88510 Idk. I don't run these games myself which is why I rely on testers to assist
@greentop Looks like an issue on linux? The vram usage on windows seems fair, but no way to be sure without direct comparison. Maybe someone with more graphics memory can check what is happening on linux version.

[alex88510]

Maybe I'll go test out the weather effect intensive area and see how much vram it used for that(although it doesn't crash on me before), after the new build is complete.

UPDATE:
As of 5b7717d, I see no performance degradation on one of the weather effect intensive area(the forest) that used to have huge performance drop.
All remains at 30fps, nice and smooth.

UPDATE2:
Tried another map which previously have huge performance drop, but right now it is still nice and smooth.

I noticed the flying snow effect was gone, not sure if it is because of my game progress.
Maybe @greentop can share the save file so that I can test it at the same spot?

[kamer1337]

Tony Hawk's Proving Ground still have black screen with gpu texture scalling or wcb

on OGL with wcb and cpu blit you can see very small part all other is black

[greentop]

(As of 5b7717d)

No game hang observed. FPS holding at a steady 30fps. 'Nvidia X Server Settings' reported memory usage peaks out at 50%.
RPCS3.log.gz
GPU usage peaks out at 59% throughout the other areas of the map.

[alex88510]

I guess the only issue left for ToCS2 is the random texture corruption, which can be annoying sometimes (when you are playing the mini card game - BLADE and can't see the card properly...).

[greentop]

The "S {rsx::thread} RSX: New program compiled successfully" lines are observed working much faster now. (Far less noticeable game pauses upon camera rotation.)
Addition 4de31dc stability & performance for ToCS2 remains in a great state for the Vulkan render.

[Kojikun1]

This PR Fixed Soul Calibur II HD online black screen, now works good

[Asinin3]

Fixed for windows too:

[Zangetsu38]

rgression for lbp karting, now game crash before show menu pod

[Kravickas]

lbp karting working same for me

[joshuacode751]

can you add borderless window? Fullscreen mode wont show trophies

[toccata10]

Dengeki_Bunko_FightingClimaxIgnition[BLJM61322] now freezes on the sega logo.
I join 2 logs: one working on rpcs3-v0.0.3-2017-10-21-96fd855-8454_linux64:
RPCS3.log-96fd855.gz
the other one which freezes on rpcs3-v0.0.3-2017-10-24-882e949-8502_linux64:
RPCS3.log-882e949.zip