rsx/qt: Fixes #3668
Merged
rsx/qt: Fixes #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2017
|
Problem #3641 is gone for me both for OpenGL and Vulkan. Although in OpenGL GS frame tries to appear, but then turns off by shader cache dialog. In Vulkan window appears only when all shaders loaded. |
|
crashes when aborting shader cache compilation |
|
Hang on sudden emulator close events is now fixed. |
|
This is specifically for the minimize error. For the other cases you have to provide a log with the sdk validation enabled. You will get detailed information before the crash similar to the one Asinin3 posted in that thread. |
|
@kd-11 This happens during minimize itself |
|
That would mean the message queue contents are different when nvidia driver is in use. That will need a special build to log window events. |
- Identify minimize/restore events as separate from regular resize and do not react to them - Enable message queue consumption after loading the shaders cache. Also hides the frame in this step -- This fixes the 'start fullscreen' bug when running vulkan
- Keeps the queue from hanging the GUI
…assed to flush_all is up to date. Should prevent recursive exceptions Partially revert Jarves' fix to invalidate cache on tile unbind. This will need alot more work. Fixes hangs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GsFrame improvements
Texture cache improvements
Fixes #3613 and #3641