Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt loops #3824

merged 5 commits into from Dec 10, 2017


None yet
4 participants
Copy link

scribam commented Dec 1, 2017

  • Trivial changes for loops in the rpcs3qt subdirectory: add const and ref where it could be useful
  • Convert spaces to tabs in the files modified by PR #3820 for consistency (nice job otherwise 馃憤)
  • std::move on a const variable has no effect

This comment has been minimized.

Copy link

jarveson commented Dec 1, 2017

Whoops, yea good catch, forgot about that. Was going to fix it after but you beat me to it :)

if (op.d)
c->lock().btr(SPU_OFF_8(interrupts_enabled), 0);
else if (op.e) {

This comment has been minimized.

Copy link

kd-11 Dec 1, 2017


move this brace to next line while you're at it

@scribam scribam force-pushed the scribam:qt-loops branch from a78a45d to e2175d7 Dec 1, 2017

@scribam scribam force-pushed the scribam:qt-loops branch from af4e0f3 to 987b395 Dec 1, 2017

@Nekotekina Nekotekina merged commit 42c2df8 into RPCS3:master Dec 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@scribam scribam deleted the scribam:qt-loops branch Dec 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.