New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve cellPadSetPortSetting #3980

Merged
merged 2 commits into from Dec 24, 2017

Conversation

Projects
None yet
3 participants
@Megamouse
Contributor

Megamouse commented Dec 24, 2017

and fix DS4 error message

This should fix a bug where Catherine and other games don't receive some buttons' input.
The bug was introduced when changing the initial connection count in PadThread.cpp.
Catherine sets the port setting on boot. but because no controller was connected this was actually skipped

Here you can see that it is called once before we connect the pads
image

@Asinin3

This comment has been minimized.

Contributor

Asinin3 commented Dec 24, 2017

Confirmed fixed, I knew I wasn't going crazy and that PR from before broke it :p

@AniLeo AniLeo merged commit fc2ef55 into RPCS3:master Dec 24, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Megamouse Megamouse deleted the Megamouse:testststts branch Dec 26, 2017

Inviuz added a commit to Inviuz/rpcs3 that referenced this pull request Jan 3, 2018

Fix cellPadSetPortSetting (RPCS3#3980)
* Don't skip setting port settings when no controller is connected
* DS4: fix error message

isJuhn added a commit to isJuhn/rpcs3 that referenced this pull request Jan 11, 2018

Fix cellPadSetPortSetting (RPCS3#3980)
* Don't skip setting port settings when no controller is connected
* DS4: fix error message

isJuhn added a commit to isJuhn/rpcs3 that referenced this pull request Jan 19, 2018

Fix cellPadSetPortSetting (RPCS3#3980)
* Don't skip setting port settings when no controller is connected
* DS4: fix error message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment