Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: fix register editor and CurrentSelectionIconPath() #4000

Merged
merged 4 commits into from Jan 13, 2018

Conversation

Projects
None yet
3 participants
@Megamouse
Copy link
Contributor

commented Dec 29, 2017

No description provided.

@Megamouse Megamouse force-pushed the Megamouse:hahaha branch 2 times, most recently from 79e1503 to 578aa66 Dec 29, 2017

@AniLeo AniLeo added Bugfix GUI labels Dec 30, 2017

@AniLeo AniLeo requested a review from Nekotekina Dec 30, 2017

@Nekotekina

This comment has been minimized.

Copy link
Member

commented Jan 6, 2018

Why is this bunch of small unrelated changes? And not all of them are necessary.

@Megamouse

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2018

why. some of the types were wrong to begin with and some other things just created annoying warnings

@Nekotekina

This comment has been minimized.

Copy link
Member

commented Jan 7, 2018

Silencing truncation with static_cast usually doesn't bring correctness, especially for size. It indicates some problem which requires "expert" attention.

@Megamouse

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2018

true. but i can't see how any of these values would ever exceed the integer limits

Qt: fix register editor
and remove a windowhint (?)

@Megamouse Megamouse force-pushed the Megamouse:hahaha branch from 085c3b2 to ffbe088 Jan 12, 2018

@Megamouse Megamouse force-pushed the Megamouse:hahaha branch from ffbe088 to 4bcdbb4 Jan 12, 2018

@Megamouse Megamouse changed the title Qt: fix register editor Qt: fix register editor and CurrentSelectionIconPath() Jan 12, 2018

@Nekotekina Nekotekina merged commit 2053de0 into RPCS3:master Jan 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.