New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Vulkan Xlib/Wayland surface support at runtime #4048
Conversation
Confirming that this fixed the issue for me. |
rpcs3/Emu/RSX/VK/VKHelpers.h
Outdated
@@ -1135,6 +1136,29 @@ namespace vk | |||
} | |||
}; | |||
|
|||
class supported_extentions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You typo'd extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol oops :D
To support drivers without Wayland surface support
e8e936d
to
62b1399
Compare
|
huh, I guess that needs the ifdef still |
|
Disregard last, found it
looks like a missing #ifdef like you posited |
The extension name is not present when VK_USE_PLATFORM_WAYLAND_KHR is not defined
{ | ||
uint32_t count; | ||
if (vkEnumerateInstanceExtensionProperties(nullptr, &count, nullptr) != VK_SUCCESS) | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add space after the return here
rpcs3/Emu/RSX/VK/VKHelpers.h
Outdated
#endif | ||
supported_extensions support; | ||
bool found_surface_ext = false; | ||
if (support.is_supported(VK_KHR_XLIB_SURFACE_EXTENSION_NAME)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brace on newline
rpcs3/Emu/RSX/VK/VKHelpers.h
Outdated
#ifdef VK_USE_PLATFORM_WAYLAND_KHR | ||
VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME, | ||
if (support.is_supported(VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
rpcs3/Emu/RSX/VK/VKHelpers.h
Outdated
found_surface_ext = true; | ||
} | ||
#endif | ||
if (!found_surface_ext) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
Detect Vulkan Xlib/Wayland surface support at runtime
No description provided.